Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help > Accessibility Options context menu should be hidden #12932

Closed
mousetraps opened this issue Sep 28, 2016 · 8 comments
Closed

Help > Accessibility Options context menu should be hidden #12932

mousetraps opened this issue Sep 28, 2016 · 8 comments
Assignees

Comments

@mousetraps
Copy link
Contributor

Testing #12519

We handle accessibility in our own way, so having the additional menu item from chromium is confusing. Not to mention, the resulting dialog itself is inaccessible (not resizeable, confusing icons, etc.)
image

Related to #12928

@joaomoreno
Copy link
Member

joaomoreno commented Sep 28, 2016

This is needed until the issue is resolved in Chromium/Electron. When it is, we'll simply remove the whole thing.

The best we could do would be to hide it better.

cc @alexandrudima @bpasero

@joaomoreno joaomoreno reopened this Sep 28, 2016
@bpasero bpasero added this to the September 2016 milestone Sep 29, 2016
@bpasero
Copy link
Member

bpasero commented Sep 29, 2016

We should take this out for the stable release and only have it in insiders.

@bpasero
Copy link
Member

bpasero commented Sep 29, 2016

Verify you see this entry in our insiders and out of sources on Windows but not in stable on Windows.

@joaomoreno
Copy link
Member

@bpasero Using devtools without this box is practically impossible... not so sure if removing it is a good idea. We ask a lot of our users to user the devtools to find out more about problems.

@bpasero
Copy link
Member

bpasero commented Sep 29, 2016

@joaomoreno in that case we can always ask them to use our insider build. which is a good advise anyways because often a bug does not show up in insiders build due to:

  • the build not being patched by a bad extension
  • the build not having the same extensions installed
  • the build already including a fix

@mousetraps
Copy link
Contributor Author

mousetraps commented Sep 29, 2016

Using devtools without this box is practically impossible...

@joaomoreno Not sure I understand... Why is this? And what's the chromium issue that you alluded to? Can't seem to find any reference to it.

@joaomoreno
Copy link
Member

A couple of weeks ago @alexandrudima got a Surface Book. He was happy until he tried Code: it was super slow. After much investigation (with @bpasero & @dbaeumer) they found the problem surfaces on certain devices only and occurs when Chrome goes into some special accessibility mode, making things very slow.

Opening the dev tools in such a device (I believe any touchscreen device would trigger it) is a painfully slow experience.

Guys, was there an issue for this? I couldn't find it.

@mrmlnc
Copy link
Contributor

mrmlnc commented Sep 30, 2016

@joaomoreno, maybe electron/electron#7208 ?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants