Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy welcome page code #130005

Closed
JacksonKearl opened this issue Aug 2, 2021 · 1 comment
Closed

Remove legacy welcome page code #130005

JacksonKearl opened this issue Aug 2, 2021 · 1 comment
Assignees
@JacksonKearl
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-welcome Welcome page issues
Milestone
August 2021

Comments

@JacksonKearl
Copy link
Contributor

This iteration I'll be removing code for the old style welcome page. It is currently available via the hidden legacy_welcomePage setting of workbench.startupEditor, but based on no feedback seeking options for enabling it I think it is safe to remove entirely.
@JacksonKearl JacksonKearl self-assigned this Aug 2, 2021
@JacksonKearl JacksonKearl added bug Issue identified by VS Code Team member as probable bug debt Code quality issues labels Aug 2, 2021
@JacksonKearl JacksonKearl added this to the August 2021 milestone Aug 2, 2021
@JacksonKearl
Copy link
Contributor Author

Assigning bug label for verification. Things to verify: if you open some welcome pages in a version that supports legacy_welcomePage, then upgrade to a version that does not support, is the failover process smooth?

@JacksonKearl JacksonKearl added the workbench-welcome Welcome page issues label Aug 2, 2021
@egamma egamma mentioned this issue Aug 16, 2021
Closed
91 tasks
@connor4312 connor4312 added the verified Verification succeeded label Aug 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-welcome Welcome page issues
Projects
None yet
Milestone
August 2021
Development

No branches or pull requests
3 participants
@connor4312 @JacksonKearl and others