Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to interact with definition hover preview #13402

Closed
ghost opened this issue Oct 9, 2016 · 7 comments
Closed

No way to interact with definition hover preview #13402

ghost opened this issue Oct 9, 2016 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality ux User experience issues
Milestone

Comments

@ghost
Copy link

ghost commented Oct 9, 2016

Since @joaomoreno's work in #2330, hovers use a widget with scrollable cells and it works very nicely for type info, docs, etc.

Definition previews for a symbol (shown when holding ⌘ on hover) can also show up in the hover widget in a scrollable cell. But in this case it seems impossible to interact with the scrollable definition preview content because the hover disappears as soon as you mouse over it if you are holding ⌘.

Is there a way to fix this?

@joaomoreno joaomoreno self-assigned this Oct 10, 2016
@joaomoreno joaomoreno added this to the October 2016 milestone Oct 10, 2016
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug ux User experience issues labels Oct 10, 2016
@joaomoreno
Copy link
Member

We can maybe make the sticky.

@joaomoreno
Copy link
Member

#2330 didn't actually break this, it's been like this for a while.

@joaomoreno joaomoreno modified the milestones: Backlog, October 2016 Oct 10, 2016
@joaomoreno joaomoreno assigned jrieken and unassigned joaomoreno Oct 10, 2016
@joaomoreno joaomoreno changed the title No way to interact with scrollable hover definition preview No way to interact with go-to-definition hover preview Oct 10, 2016
@joaomoreno joaomoreno changed the title No way to interact with go-to-definition hover preview No way to interact with definition hover preview Oct 10, 2016
@jrieken
Copy link
Member

jrieken commented Oct 10, 2016

impossible to interact with the scrollable definition preview content

As in scroll and copy&paste or what else do you have in mind

@joaomoreno
Copy link
Member

I believe he just wants to use the mouse to select text in there and copy-paste stuff yeah. I guess for that we'd need to be able to release and still see the preview.

@jrieken jrieken added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Oct 10, 2016
@ghost
Copy link
Author

ghost commented Oct 10, 2016

@jrieken I was really only hoping for being able to scroll the preview since sometimes it will show up with more content than fits in the cell. So anything beyond that (e.g., copy&paste) would be icing on the cake.

@aniljava
Copy link
Contributor

aniljava commented Dec 26, 2016

I like to add following for consideration:

  • Similar to eclipse, click on hover box makes it sticky.
  • Currently mouse out of box closes the hover box. If the hover box is sticky, close only after mouse is clicked outside the box or after mouse out for certain time. That way if some one was selecting or scrolling do not have to restart the scrolling and selecting process again if mouse accidentally leaves the boundary.
  • Also allow resize once the box is clicked (side, bottom, bottom corner) . This helps wrapped content to get unwrapped and provide a better view.
  • For links in the content of hover. If pointed object can be rendered in hover, render on same box for normal click, and new tab if it is a ctrl + click.
  • User configurable option to specify preference on location of hoover (when screen/editor permits). Possible selections : [bottom, bottom-start-at-end-of-identifier, top .. ]

@jrieken
Copy link
Member

jrieken commented Nov 17, 2017

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!

@jrieken jrieken closed this as completed Nov 17, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality ux User experience issues
Projects
None yet
Development

No branches or pull requests

3 participants