-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sponsor deserves more visual real estate #150830
Comments
First two look great and just loud enough. We could add a blurb with link in the hover (similar like we have for verified). |
I understand the interest behind making this feature visible to users. But I am not convinced that this has to be shown as a primary action in the extensions view. Sponsoring is not something users often do when compared to other actions like For example, GitHub also does not render if a project can be sponsored when browsing for projects. One can only sponsor when you open the project.
I disagree. Verified publisher gives an impression to the user that the extension can be somewhat trusted, where as sponsor action does not - this is requesting user to sponsor. Imagine if the publisher is not verified but still has sponsor action? How can I take a decision to sponsor. There is no enough information in the extension view for this. We shall always drive users to open the extension and provide as enough information as possible before they decide to sponsor.
I am sorry that adding an icon adds noise because extensions viewlet has very less real estate. Please see following If the intention is to make it discoverable, I would explore the badge area which is intended for similar purposes like this
Or let's come up with some smart model that periodically checks if user is using an extension for a long time and ask if user would like to sponsor those extensions. |
@sandy081 good feedback and ideas, thanks. Your idea for a smart model that periodically checks might work, my worry is that we would have to use notifications for it - I do not see a better way to ask the user to sponsor? |
Can you please elaborate more on this?
Is it possible to show the stack of badges from top to bottom? Can be a good UX challenge to solve?
I agree. I think we shall explore some Notification Center in extensions view for extensions specific prompts like this. It might be helpful to inform extensions that need attention like reload required, outdated, deprecated, sponsored etc. Finally, I am still not able to understand why we want to make sponsor badge a first class concept? We are not doing the same for rating? IMO, rating an extension improves the extension eco system and adds more value to VS Code users and community. |
I think that sponsoring probably brings more total value to the ecosystem than giving a rating. And for ratings users get introduced to them when they install the extension (we show ratings then). After that user can go to the extension details to rate. For multiple badges stacked on top - I live this to @daviddossett when he finds time (nothing urgent) For the notification center idea - this might be just showing a badge in the extension view. The badge might go away once the user opens the view. I do not think we need something too heavy for this. |
One idea that came out of discussion between @isidorn and me is to add Sponsor / Rating to hover. |
Interesting idea. I can quickly sketch this at some point this week. Stay tuned. |
@daviddossett we thought that the messaging should be something like "help make the extension ecosystem better by rating or sponsoring NAME_OF_EXTENSION" Of course we are open to other ideas :) |
@daviddossett this might work great. I would hate to add too much noise. |
When I implemented custom hovers for extensions, I was including rating in the hover and removed it later. I pulled those changes now and added sponsor and this is how it looks: It aligns with extension editor representation. Note that I also moved Sponsor action to the header in the editor. What do you think about
|
Reopening it for further discussions |
@sandy081 I just tried this out from source and feels great to me. Both the hover, and the move to the header section. I am talking to Anup on the Marketplace side to get his thinking about the MP rendering - ideally we would also do it in the header section there. My only feeling is that the color does not work for dark theme. Not enough contrast. Unrelated to this. "This extension is enabled globally" - I suggest to not have a hover for this, only if the extension is disabled does this deserve a message. If we remove this the hover will be lighter. Is there some benefit of this message that I am missing? |
My bad, I did not check this in Dark theme. @misolori I need your help again to tweak the colour. Also can we have filled heart icon?
Since we have different enablements, it is helpful to show it. |
@sandy081 also I am not sure if the letters should be coloured. I think it will be nicer if they are just white. Notice how the verified has an icon and then Xdebug is without colour. So the <3 should be colured but not the "Sponsor" Also Lydia was thinking the same when she did the initial mock |
@sandy081 as for full or empty heart. Both work for me. Whatever you, @daviddossett think is best. |
@sandy081 previously the colors were being used as a background color in a button, do we envision this not being used anymore or do we need separate color tokens? |
@misolori we envision those not being used anymore. We are leaning towards this design now it seems :) |
@isidorn Closing this in favour of the improvements done. Please verify them. Lets track any new ideas/suggestions in a separate issue |
Testing #150748
We already discussed this offline but creating an issue so we potentially revisit this in the future.
Currently we render a ❤️ Sponsor button in the Extension details and it is great.
However I still think that we should add a simple ❤️ in the extension viewlet if an author has on-boarded to the sponsor. Here's my reasoning:
Design proposal: similar that we have the verified checkmark before the publisher. We could render the heart after the publisher area.
fyi @daviddossett @misolori for thoughts
The text was updated successfully, but these errors were encountered: