Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only the first error gets a shell integration decoration #153477

Closed
alexr00 opened this issue Jun 28, 2022 · 6 comments
Closed

Only the first error gets a shell integration decoration #153477

alexr00 opened this issue Jun 28, 2022 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *out-of-scope Posted issue is not in scope of VS Code tasks Task system issues windows VS Code on Windows issues

Comments

@alexr00
Copy link
Member

alexr00 commented Jun 28, 2022

Testing #153365

  1. Open microsoft/vscode
  2. Run the default build task
  3. Make some build errors
  4. Fix the build errors
  5. Make some new build errors
  6. Only the first errors will get a decoration. Subsequent ones are missing the decoration.
    image
@meganrogge
Copy link
Contributor

this is by design - we only mark the first of a set of errors

@meganrogge meganrogge added the *as-designed Described behavior is as designed label Jun 28, 2022
@vscodenpa
Copy link

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@Tyriar
Copy link
Member

Tyriar commented Jun 28, 2022

@meganrogge we expect dots at the red rectangles?

image

@meganrogge meganrogge reopened this Jun 28, 2022
@meganrogge
Copy link
Contributor

Oh yep, read the description and didn't look closely enough at the screenshot

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug tasks Task system issues and removed *as-designed Described behavior is as designed labels Jun 28, 2022
@Tyriar Tyriar added this to the June 2022 milestone Jun 28, 2022
@Tyriar
Copy link
Member

Tyriar commented Jun 28, 2022

Added to June, might be hard to fix Windows shenanigans though.

@meganrogge meganrogge added the windows VS Code on Windows issues label Jun 28, 2022
@meganrogge meganrogge modified the milestones: June 2022, July 2022 Jun 30, 2022
@Tyriar
Copy link
Member

Tyriar commented Jul 8, 2022

I haven't seen this in my normal operation but I believe what is going on here is a combination of the fact that conpty doesn't guarantee the position of the escape sequences and our build task deemon replays a bunch of content. Closing as this should get fixed when conpty positions OSC 633 correctly (which is in progress).

@Tyriar Tyriar closed this as completed Jul 8, 2022
@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Jul 8, 2022
@rzhao271 rzhao271 removed this from the July 2022 milestone Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug *out-of-scope Posted issue is not in scope of VS Code tasks Task system issues windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

5 participants