Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use watchman as backend for file watching #156964

Closed
bpasero opened this issue Aug 3, 2022 · 3 comments
Closed

Allow to use watchman as backend for file watching #156964

bpasero opened this issue Aug 3, 2022 · 3 comments
Labels
feature-request Request for new features or functionality file-watcher File watcher *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Aug 3, 2022

This came up in #156690 (comment)

//cc @vilk-stripe

@bpasero bpasero added feature-request Request for new features or functionality file-watcher File watcher labels Aug 3, 2022
@bpasero bpasero added this to the Backlog milestone Aug 3, 2022
@jvilk-stripe
Copy link

If you surface this in an experimental option, let me know and we can try it out for our use case at Stripe. This would make our local development and remote development workflows more efficient.

@bpasero
Copy link
Member Author

bpasero commented Aug 2, 2023

A quick test on macOS running with watchman backend shows that not all of our parcel watcher integration tests pass with that backend:

4 failing

  1) File Watcher (parcel)
       subsequent watch updates watchers (path):

      
      + expected - actual


  Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

  2) File Watcher (parcel)
       wrong casing:

      
      + expected - actual


  Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

  3) File Watcher (parcel)
       deleting watched path is handled properly:

      
      + expected - actual


  Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

  4) File Watcher (parcel)
       "after each" hook for "deleting watched path is handled properly":

      
      + expected - actual


  Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

@bpasero bpasero added the *out-of-scope Posted issue is not in scope of VS Code label Oct 12, 2023
@vscodenpa
Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality file-watcher File watcher *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants