Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode should register itself as a default terminal. #171102

Closed
RokeJulianLockhart opened this issue Jan 11, 2023 · 8 comments
Closed

VSCode should register itself as a default terminal. #171102

RokeJulianLockhart opened this issue Jan 11, 2023 · 8 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label

Comments

@RokeJulianLockhart
Copy link

Currently, in Windows, the sole terminals that register themselves as available defaults at the OS level are Windows Terminal (Preview) and cmd.exe. (Not even Fluent Terminal is able to yet.)

Windows Terminal is a good terminal, but when compared to VS Code's, I see many reasons to prefer VS Code's terminal.

Consequently, I suggest that Visual Studio Code register itself as an available default terminal.

@meganrogge
Copy link
Contributor

/duplicate #34442

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 11, 2023
@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Jan 11, 2023

@meganrogge, this isn't duplicate. I don't care whether the terminal is able to be extracted from the main window. Just having a window with merely a terminal in is adequate for me, since it's barely any different to Windows Terminal's current interface.

Consequently, please revert your decision to triage this as duplicate and close it.

@meganrogge
Copy link
Contributor

This would require introducing a CLI for the terminal which is what the issue I cited above requires. we take note of duplicates to see what we should prioritize in the upcoming iterations, so thank you for creating the issue 👍🏼

@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Jan 11, 2023

@meganrogge, is the terminal itself not a CLI? I apologize, for I feel like I'm wasting time asking for explanations of simple things, but surely these are separate. Even completing the linked issue wouldn't remediate this problem, because it wouldn't allow VS Code to register as a default terminal.

Not merely any terminal is able to be defined as the OS default. That was why I linked felixse/FluentTerminal#965 – it was to demonstrate that Windows Terminal and cmd.exe are the only ones that currently support this feature, so it must be manually supported by the developers.

@meganrogge
Copy link
Contributor

I'll reopen this issue to track making it an OS default, but this is blocked by / related to #34442, which we'd have to complete before we could consider this

@meganrogge meganrogge reopened this Jan 11, 2023
@meganrogge meganrogge added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label and removed *duplicate Issue identified as a duplicate of another issue(s) labels Jan 11, 2023
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Jan 11, 2023
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@Tyriar
Copy link
Member

Tyriar commented Jan 12, 2023

@RokeJulianLockhart the terminal itself is not a CLI; you cannot control the VS Code terminal via the code CLI.

Since one of the primary deliverables of #34442 is to make a cli and registering it as a default is part of that, we're already tracking it there. Keeping another issue open is just extra clutter for us to manage, we just did issue grooming to get our issue count to a more sane value and we want to try keep it manageable.

It's the 11th highest voted issue in the repository so it's definitely on our radar.

@Tyriar Tyriar closed this as completed Jan 12, 2023
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 12, 2023
@Tyriar Tyriar removed this from the Backlog Candidates milestone Jan 12, 2023
@RokeJulianLockhart
Copy link
Author

Understood. @Tyriar, if the team considers this to be a necessary step in considering #34442 to be complete, I'll trust ya.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

4 participants