Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow to have different settings by filename #172966

Closed
1 task
iliubinskii opened this issue Jan 31, 2023 · 3 comments
Closed
1 task

Feature: allow to have different settings by filename #172966

iliubinskii opened this issue Jan 31, 2023 · 3 comments
Assignees
Labels
*caused-by-extension Issue identified to be caused by an extension *extension-candidate Issue identified as good extension implementation

Comments

@iliubinskii
Copy link

Tasks

Preview Give feedback

Use case:
I am using a plugin that sorts .json files.
It has "orderOverrideKeys" setting that allows to place certain keys at the top.
For example, you may want to place "name", "description", "keywords" above all other keys.
I am using this plugin to sort files like manifest.json (for mobile apps), composer.json (for PHP projects), and other.
Obviously, it would be much cleaner to have separate "orderOverrideKeys" list for manifest.json, composer.json, and some other json configuration files that have standard name.

@rzhao271
Copy link
Contributor

Hi, I can understand wanting different setting values for some specific files, but I think that'd be better implemented as an object setting in the extension you are referring to. For example, the keys of that object setting could be the filenames, and the values could be the ordering of keys to use for a file with that filename.

@rzhao271 rzhao271 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
@rzhao271 rzhao271 added *caused-by-extension Issue identified to be caused by an extension *extension-candidate Issue identified as good extension implementation labels Jan 31, 2023
@iliubinskii
Copy link
Author

iliubinskii commented Feb 1, 2023

Actually I mentioned one use case, but I think the feature I suggest can be useful for configuring many extensions and extension owners may not always want to change it. So I would suggest at least to keep this thread open to see if other use cases follow.

@rzhao271
Copy link
Contributor

rzhao271 commented Feb 1, 2023

It turns out there are other use cases 👀
Duplicate of #35350

@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension *extension-candidate Issue identified as good extension implementation
Projects
None yet
Development

No branches or pull requests

2 participants