Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested git repo detection for symlinked repo #173766

Open
lonix1 opened this issue Feb 8, 2023 · 1 comment
Open

Nested git repo detection for symlinked repo #173766

lonix1 opened this issue Feb 8, 2023 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality git GIT issues
Milestone

Comments

@lonix1
Copy link

lonix1 commented Feb 8, 2023

A few months ago we got a new feature for detecting nested git repos: feature, PR.

But it doesn't handle the use case where the repo is in a symlinked directory. We have a number of common repos used in many monorepos, and they're referenced as symlinks:

MyMonoRepo/
  .git/
  lib/
    NormalNestedRepo/                  <--- detected
      .git/
    SymlinkedNestedRepo/               <--- not detected
      .git/
  src/

The symlinked repo is not detected.

(Unless this is already supported somehow @lszomoru @nteymory ?)

@lszomoru lszomoru added feature-request Request for new features or functionality git GIT issues labels Mar 27, 2023
@lszomoru lszomoru added this to the On Deck milestone Mar 27, 2023
@lszomoru
Copy link
Member

@lonix1, apologies for not getting back to you on this until now. There are several features (#5970) that are not working as expected when there is a symbolic link on the path of the git repository. I expect that this is something that we will look at when we try to tackle the symbolic link support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality git GIT issues
Projects
None yet
Development

No branches or pull requests

2 participants