Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have terminal support Unicode version 14 #178677

Closed
erf opened this issue Mar 30, 2023 · 3 comments
Closed

Have terminal support Unicode version 14 #178677

erf opened this issue Mar 30, 2023 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@erf
Copy link

erf commented Mar 30, 2023

I'm working on a terminal app and i noticed that the width of some characters e.g. the red heart emoji "❤️" is only one character, whilst in Unicode 14 it takes up 2 columns, and this messes up the cursor position for me as I'm using a package to calculate the character width based on the latest standard.

I can read in the settings that you only support Unicode version 6 and 11 and would like to suggest that you also support Unicode version 14 (or even 15?).

Relevant setting:

terminal.integrated.unicodeVersion
@luv-deluxe
Copy link

@erf
In powershell console I have
image

but in integrated VS one I see
image

Is there a chance it is connected with this issue?

@Tyriar
Copy link
Member

Tyriar commented May 24, 2023

Unicode v15 support is likely coming with xtermjs/xterm.js#4519

@luv-deluxe the unicode version only determines the width of the characters, your issue is tracked in xtermjs/xterm.js#2693

@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels May 24, 2023
@Tyriar Tyriar added this to the Backlog milestone May 24, 2023
@Tyriar
Copy link
Member

Tyriar commented Dec 10, 2024

Let's track this upstream: xtermjs/xterm.js#2693

/duplicate

@Tyriar Tyriar closed this as completed Dec 10, 2024
@vs-code-engineering vs-code-engineering bot added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

4 participants