Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git extension fails to get correct soft linked repo root #181676

Closed
frankli0324 opened this issue May 6, 2023 · 2 comments
Closed

git extension fails to get correct soft linked repo root #181676

frankli0324 opened this issue May 6, 2023 · 2 comments
Assignees

Comments

@frankli0324
Copy link
Contributor

frankli0324 commented May 6, 2023

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: Version: 1.78.0 (Universal) Commit: 252e546

Steps to Reproduce:

  1. open a git repo that is inside a folder that is linked to another path

Reason:

vscode git extension uses the command git rev-parse --show-toplevel to find the repo roots:

https://github.com/microsoft/vscode/blob/main/extensions/git/src/git.ts#L481-L484

however, when in cases where repo is located at a linked path, git returns the realpath instead.

@frankli0324
Copy link
Contributor Author

frankli0324 commented May 9, 2023

Do you have time to look into this? @lszomoru

@lszomoru
Copy link
Member

@frankli0324, thanks for filing this issue. It is known that VS Code does not currently handle git repositories that have a symbolic link on their path, for the reason that you have described. The work to support this scenario is tracked in #5970. I will go ahead and close this issue and ask you to subscribe to that issue to keep track of the progress.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants