Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move off of Keytar #185677

Closed
6 tasks done
TylerLeonhardt opened this issue Jun 20, 2023 · 2 comments
Closed
6 tasks done

Move off of Keytar #185677

TylerLeonhardt opened this issue Jun 20, 2023 · 2 comments
Assignees
Labels
authentication Issues with the Authentication platform engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes on-testplan
Milestone

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jun 20, 2023

With node-keytar now archived and unmaintained, we need a path forward for securely storing secrets and additionally, reflect the fact that we do not need to follow the shape of keytar anymore.

On Desktop, we will take advantage of Electron's safeStorage API. We will also get rid of vscode-encrypt because it would be providing no benefit in this new world.

Additionally, we will remove the KeytarShim that has been in the product. This was the solution to secrets before the SecretStorage API.

Outlined are the steps to get this done:

Tasks

  1. 3 of 3
    authentication debt
    TylerLeonhardt
  2. authentication debt
    TylerLeonhardt
@TylerLeonhardt TylerLeonhardt added this to the June 2023 milestone Jun 20, 2023
@TylerLeonhardt TylerLeonhardt added feature-request Request for new features or functionality engineering VS Code - Build / issue tracking / etc. authentication Issues with the Authentication platform labels Jun 20, 2023
@TylerLeonhardt
Copy link
Member Author

Closing since everything is done or captured in a follow up issue

@tomduncalf-figma
Copy link

Hey @TylerLeonhardt, I just wanted to flag that the behaviour of the secret store onDidChange listener appears to have changed in a surprising way since it was migrated away from keytar: #187247

@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
authentication Issues with the Authentication platform engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes on-testplan
Projects
None yet
Development

No branches or pull requests

3 participants