Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode 1.8.1. HTML bad automatic identation #18739

Closed
pedrojfpereira opened this issue Jan 18, 2017 · 6 comments
Closed

VSCode 1.8.1. HTML bad automatic identation #18739

pedrojfpereira opened this issue Jan 18, 2017 · 6 comments
Assignees
Labels
html HTML support issues info-needed Issue requires more information from poster

Comments

@pedrojfpereira
Copy link

  • VSCode Version: Code 1.7.2 (7ba55c5, 2016-11-21T22:06:37.428Z)
  • OS Version: Windows_NT ia32 6.3.9600
  • Extensions:
Extension Author Version

Steps to Reproduce:

  1. VSCODE 1.8.1 is making bad automatic HTML code identation
  2. VSCODE 1.7.1 had better automatic HTML code indentation
@schmuli
Copy link

schmuli commented Jan 18, 2017

This is probably because of js-beautify: beautifier/js-beautify#1103

@mjbvz mjbvz added html HTML support issues info-needed Issue requires more information from poster labels Jan 19, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 19, 2017

@pauloppenheim Can you please provide some example code that show this problem? Also, please try running VSCode with --disable-extensions to make sure an extension is not the root cause

Thanks

@aeschli
Copy link
Contributor

aeschli commented Jan 19, 2017

likely a duplicate of #17849.
@pauloppenheim Do you have any style or event handler attributes?

@aeschli
Copy link
Contributor

aeschli commented Jan 30, 2017

Closing due to lack of more information. Please have a look at the latest insiders where #17849 is fixed and where jsbeautify has been updated.

@aeschli aeschli closed this as completed Jan 30, 2017
@HookyQR
Copy link
Contributor

HookyQR commented Feb 10, 2017

This is a legit issue. See the link provided by @schmuli. It's a js-beautify bug. I've submitted a PR to fix it, but (once it's accepted) VS Code will need to apply the fix to the included module. (Under the html language server)

@HookyQR
Copy link
Contributor

HookyQR commented Feb 10, 2017

I've implemented the fix directly in beautify. So if you want proper formatting first, install or upgrade that extension.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
html HTML support issues info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

5 participants