-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an option to enable DirectWrite #1896
Comments
+1 |
cc @egamma @bpasero Looking at electron/electron#3349 looks like we still have a blurry font issue on windows until we adopt an Electron version with Chrome 47 -- the patch of Electron v0.34.4 only covers Linux. |
@alexandrudima yup |
👍 |
We can only solve this by updating Electron to a newer version but currently are blocked because of a native node crash. |
For reference, he is talking about electron/electron#4299 |
FWIW, this is also true on OSX (10.11.3) with 96 DPI monitors, but setting the zoom level to vscode to anything other than default (e.g. I have It appears to be related to 'subpixel' scrolling of the editor text area. Might be different issue, however. |
i think the issue should be fixed by electron, Chrome has no problem. |
@iHuahua that is definitely not a workaround. Having a Windows 10 installation on a 4k monitor without scaling is absolutely tedious to say the least (I'd like to preserve my eyesight for the next years...). |
Interesting, so you say the explorer is always sharp but the editor is not for you? |
exactaly. and It realy seems to be a GPU rendering issue. |
@artsjedi What settings are you using and what theme is that? |
@alexandrudima default dark theme. using windows 10, febury updated, on surface pro 3. 2016-02 build. |
We pushed a major update to the UI framework to our insiders release and would appreciate feedback if this issue got resolved. You can give it a try from our insiders release today: http://code.visualstudio.com/Download#insiders Happy for feedback! |
On a Surface Pro (150% scaling) attached to an external monitor (100% scaling), 1.0.1-insider still has blurry UI elements. All the screenshots below are scaled so the 100% versions are shown at actual size. I think it's definitely getting better though. |
I'm not sure this is specific to Windows; here's screenshots of VS Code (1.20.0) from my MacBook (Mac OS High Sierra) connected to a monitor. Left is the MacBook (2017 12" MacBook) screen and right is the external screen (an LG 29" 1080p Ultrawide). As mentioned above; it's not just the editor, all of the text including tabs and explorer are blurry on the external screen. Happens even if I launch Code on the second display, so I don't think it's related to dragged the window from one to the other. |
The same thing on Manjaro |
This is the very strange thing, that people trying different solutions related to GPU, and did not realize that the issues in some cases (I can confirm that) with Nvidia control panel and FXAA (and option below) Try to play with Antialiasing FXAA option if you have Nvidia graphics card, and the issue will be solved. |
@Anacondaqq where is Aliasing FXAA option on Manjaro Gnome? |
@alien2003 Sorry, I do not know. But my comment is correct, and I can, again and again, confirm that. |
I solved this with update my driver and set conservative morphological anti-aliasing to off |
@jacob-arlington how to do it on Manjaro Gnome? |
@alien2003 what is your graphic card? |
@jacob-arlington Intel® HD Graphics 620 (Kaby Lake GT2) |
My issue on second monitor fixed by changing DPI setting to 100%. |
@bpasero the problem with DirectWrite on windows. If you have a way to return back DirectWrite flag (chrome://flags) like on CentBrowser to turn off DirectWrite and render all text via GDI+ the solution will solve the issue. Btw, these 1.28 builds run SO smoothly and fast. Noticeable differences. Good work. |
@bpasero This exploration build fixed the blurriness on my 43' 4K monitor scaled to 125% on 3840 x 2160. Thanks!! |
I'm experiencing a similar issue in Linux although in this case it seems to be due to a non-uniform aliasing effect across the screen. The following are 2 screenshots taken on: The font used is Here you can see a rainbow-like effect across the screen. The pattern changes every Size Using In contrast the same font and size on What is even more disturbing is that the font renders perfectly in the embedded terminal: |
Given #15211 (comment) there will be a way to configure Chrome command line switches to be used on each startup. If there is a specific flag that makes the situation better for users, please let me know and we can think about supporting it there. Otherwise I would like to close this issue as it seems not actionable from the VSCode side of things. |
@DanTup I'm noticing the same with my macbook vs ultrawide monitor. However, I find that the fonts of my Terminal window are extremely clear even on the ultrawide. Were you able to figure out how to make the text sharp on VScode by any chance? Thanks! |
@jeanabraham I didn't figure it out - I tend to always use VS Code directly on the MacBook screen instead. My terminal is also fuzzy on the external screen - though I remember seeing some popup about terminal performance once offering to change renderer - I don't remember if I agreed or not, but maybe that's a reason for a difference. |
@DanTup thanks! Ok. I decided I'll just trade in my ultrawide for 4k instead! |
It's kinda funny that that might be the easiest fix 😄 |
I am using VS Code on a 4k monitor (ASUS PB287Q 4K) and have set Windows 10's scaling on that monitor to 150%. VSCode fonts inside the editor are extremely blurry.
Look at this example (scaling in Windows 10: 150%,
editor.fontSize:
: 13,window.zoomLevel
: 0):The code in the background is very blurry (please open the image in a new tab to really see it), while the dialog in the foreground is not (just for comparison).
I tried to play around with the
edtior.fontSize
/window.zoomLevel
options, but there isn't any way to get the font crisp. Using--disable-direct-write
and--force-device-scale-factor=1.0
to start VS Code also doesn't fix the issue.The text was updated successfully, but these errors were encountered: