Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies between vscode-uri and uri typings #190584

Open
vince-fugnitto opened this issue Aug 16, 2023 · 2 comments
Open

Inconsistencies between vscode-uri and uri typings #190584

vince-fugnitto opened this issue Aug 16, 2023 · 2 comments
Assignees
Labels
debt Code quality issues uri

Comments

@vince-fugnitto
Copy link

Description

The vscode-uri module and typings from the application are inconsistent, is this expected?

For instance, the interface UriComponents is defined differently:

export interface UriComponents {
	scheme: string;
	authority: string;
	path: string;
	query: string;
	fragment: string;
}
export interface UriComponents {
	scheme: string;
	authority?: string;
	path?: string;
	query?: string;
	fragment?: string;
}

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.81.1
  • OS Version: Ubuntu 20.04.6 LTS

Steps to Reproduce:

  1. N/A
@jrieken jrieken added the uri label Aug 16, 2023
@jrieken jrieken added the debt Code quality issues label Dec 5, 2023
@jrieken
Copy link
Member

jrieken commented Dec 5, 2023

This should be fixed vscode-uri

@tsmaeder
Copy link

tsmaeder commented Dec 8, 2023

@jrieken "should" as in "I think it is", or as in "needs action"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues uri
Projects
None yet
Development

No branches or pull requests

3 participants