Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option "never" for showing inline suggestion toolbar #198070

Closed
gugeonmo opened this issue Nov 13, 2023 · 4 comments · Fixed by #198227
Closed

Add an option "never" for showing inline suggestion toolbar #198070

gugeonmo opened this issue Nov 13, 2023 · 4 comments · Fixed by #198227
Assignees
@hediet
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2023

Comments

@gugeonmo
Copy link

Inline Suggestion Toolbar

drawing

Current Feature

Currently, we can control when to show the inline suggestion toolbar by setting editor.inlineSuggest.showToolbar to "always" or "onHover", which are defined as follows:

  • "always": show the inline suggestion toolbar whenever an inline suggestion is shown, and
  • "onHover": show the inline suggestion toolbar when hovering over an inline suggestion.

New Feature

For the new feature, I suggest to add an option "never" as follows

  • "never": do not show the inline suggestion toolbar.
@hediet hediet added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality labels Nov 13, 2023
@hediet hediet added this to the Backlog milestone Nov 13, 2023
@hediet
Copy link
Member

hediet commented Nov 13, 2023

I think this should be very easy to implement. Up for a PR?

@hsfzxjy
Copy link
Contributor

hsfzxjy commented Nov 14, 2023

I would like to take this.

@hsfzxjy hsfzxjy mentioned this issue Nov 14, 2023
Merged
@cyfyifanchen
Copy link

Any ideas why this setting isn't in the Settings JSON file? "editor.inlineSuggest.showToolbar": "onHover".

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 15, 2023
@gugeonmo
Copy link
Author

Thank you so much for accepting the request and for the contribution!

@rzhao271 rzhao271 modified the milestones: Backlog, November 2023 Nov 27, 2023
@hediet hediet added the verification-needed Verification of issue is requested label Nov 28, 2023
@jrieken jrieken added the verified Verification succeeded label Nov 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2023
Development

Successfully merging a pull request may close this issue.

Add inlineSuggest.showToolbar.never hsfzxjy/vscode
7 participants
@jrieken @cyfyifanchen @hediet @hsfzxjy @rzhao271 @vscodenpa @gugeonmo