Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Multi-Document Occurrence Highlighting #199252

Closed
2 tasks done
Yoyokrazy opened this issue Nov 28, 2023 · 1 comment
Closed
2 tasks done

Test: Multi-Document Occurrence Highlighting #199252

Yoyokrazy opened this issue Nov 28, 2023 · 1 comment

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Nov 28, 2023

Refs: #198469, #196354

Complexity: 3

author: @Yoyokrazy

Create Issue


Summary:

This iteration we introduced API to contribute multi-document highlight providers. As a first step, the typescript-language-features builtin extension now registers a multi-document provider, and supports semantic highlighting out of the box accross multiple files. This is driven by the Editor: Occurrences Highlight enum setting. This TPI is meant to test the behavior of the new semantic provider and the textual providers that lie underneath as a fallback.

Steps to Test:

  • Paste the following into your settings.json file: "editor.occurrencesHighlight": "multiFile"
  • Open multiple files in your workspace, several Typescript files, a notebook, and a file of another language (python, rust, etc).
  • Highlight a variable inside the typescript file that you would expect to have semantically highlighted accross the two .ts files. (ex: a class definition in one file, and an object of that class in another file). Ensure that only semantic occurrences are highlighted here, and the class name isn't highlighted within a comment elsewhere.
  • Click an import statement within a typescript file and ensure that the word "import" is not highlighted across multiple files.
  • Ensure that while using semantic highlighting in a ts file, you are not getting highlights within non-ts files even if they contain the variable name.
  •  Highlight a variable within a notebook (this will use a textual occurrence provider) and ensure that the highlights carry across cells, but do not carry over into any other files or notebooks.
  • Continue highlighting with different workspace states and ensure that the standard highlights within your single file are navigable and are being presented as expected.

Please file issues if there is unexpected behavior or UX bugs!


Thanks so much for testing!

@ulugbekna ulugbekna added this to the November 2023 milestone Nov 28, 2023
@jrieken jrieken removed their assignment Nov 28, 2023
@cwebster-99
Copy link
Member

LGTM!

@cwebster-99 cwebster-99 removed their assignment Nov 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants