Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@summary jsdoc support #24372

Closed
Almenon opened this issue Apr 9, 2017 · 5 comments
Closed

@summary jsdoc support #24372

Almenon opened this issue Apr 9, 2017 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues
Milestone

Comments

@Almenon
Copy link

Almenon commented Apr 9, 2017

========= Feature Request ============

It would be nice if @summary and @description paramaters were recognized in jsdocs to provide better intellisense. I'd consider the description of what the function does to be more important than its types. Visual Studio already has this feature.

@mjbvz mjbvz added feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Apr 10, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 10, 2017

Thanks. This is being tracked upstream on the TypeScript side: microsoft/TypeScript#13650

@mjbvz mjbvz closed this as completed Apr 10, 2017
@mjbvz mjbvz added this to the May 2017 milestone May 10, 2017
@mjbvz mjbvz removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label May 10, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 10, 2017

This should now be fixed. For the code:

/**
 * @summary 
 * Get Document body.
 *
 * @description
 * Get the document body of the view. Sometimes, it is useful to render an
 * alert view or notify the user of something that have happened. These views
 * are owned by the document body, so to reference the document body, you use
 * `this.document`. And it is only, `ContentBaseView` and it derivatives that
 * has a reference to the document body.
 *
 * @example
 * 
 * ```
 * render () {
 *     return (
 *         <div className='NameField'>{this.l('NAME_FIELD')}</div>
 *     );
 * }
 * ```
 */
function getDocument() {
    return '';
}

For hover we now display:

screen shot 2017-05-10 at 4 31 45 pm

and for completion items we display:

screen shot 2017-05-10 at 4 39 33 pm

This info is currently not rendered as markdown due to #11877

@Almenon
Copy link
Author

Almenon commented May 11, 2017

thanks @mjbvz !

@wesleymostien
Copy link

What about the @return info?

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 18, 2017

@wesleymostien Opened #36462 for that

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

3 participants