Terminal link detection only works after scrolling

[coreh]

• VSCode Version: 1.17.0
• OS Version: OS X 10.12.6

Steps to Reproduce:

1. On the terminal, run a command that outputs a URL
2. Hover the link with the mouse. VSCode will not recognize it as clickable
3. Scroll the terminal up/down
4. VSCode will now recognize the link and Cmd+Click will work

Also tested on Windows 10, same results.

Edit: Just got the 1.17.1 update, the bug is still present

Reproduces without extensions: Yes

[Tyriar]

This was mostly fixed in 1.17.1 (#35662) but it occasionally still doesn't work.

[scorredoira]

I am using 1.17.2 and the problem is still present.
Also after scrolling the problem disappears.

[Tyriar]

Was the terminal hidden before hovering the link? If so this could be #37103

[scorredoira]

No, it was visible all the time. Also I checked for errors in the Developer Tools Console and has none.
And scrolling just a little makes it work again.

[scorredoira]

It seems totally random. I'm doing all kind of tests to reproduce it but I can't find a pattern.

[scorredoira]

It's also present in Version 1.18.0-insider. I have done now ~50 tests and it is random.

[coreh]

It's not happening randomly for me, I get it consistently every single time

[gwk]

@scorredoira @coreh my experience (with file paths, not urls) is that it seems reproducible, and has to do with the the terminal buffer filling up enough to scroll. However just a couple of times I didn't quite see what I was expecting, so I'm not sure if the bug is totally deterministic. Are you able to see the same behavior as I described in #37453?

[scorredoira]

@gwk my experience is also with file paths. The behavior I see like #37453 but only about 10-20% of the times

[scorredoira]

I thought I had narrowed it and that links only stopped working the moment there was enough content for the scrollbar to appear. I did multiple tests with a fresh terminal each time. It behaved that way for 5 or 6 times but then It started to fail the first link and not the following until the scroll kicked in. Worked the same way a few times and the a different pattern. So it is definitely random for me.

In case it helps, when I see a pattern it repeats itself for a few times and then it changes.

[coreh]

One interesting thing that I noticed is that even links that were previously correctly detected as URLs (by scrolling up/down) stop working as soon as a new line gets added, even if that newline doesn't itself contain any links.

Using something like tmux (that hijacks the new line command and instead draws characters at specific positions via curses) completely bypasses the issue.

[Tyriar]

Using something like tmux (that hijacks the new line command and instead draws characters at specific positions via curses) completely bypasses the issue.

This is probably the case because tmux never actually scrolls. Scrolling within tmux just redraws the viewport.

[Tyriar]

I think I found the fix xtermjs/xterm.js#1234