Add support for "e.key" keybindings in extension's contributes.keybindings

[aioutecism]

I'm encountering this problem when dealing with different keyboard layout in extension.

Say I have these in my extension's package.json:

{
  "contributes": {
    "keybindings": [
      {
        "key": "\\",
        "command": "myExtension.backSlash"
      }
    ]
  }
}

I'm trying to map \ here.
However, what VSCode actually does is map VK_OEM_5 to myExtension.backSlash.
Therefore, I get \ => myExtension.backSlash on US keyboard (which is correct) but # => myExtension.backSlash on British keyboard (which is wrong), which is not correct.

I've done a workaround to deal with different keyboard layouts here.
But users have to add a setting in configuration in order to tell the extension the layout they are using.
This is troublesome and extension shouldn't do all the handling of keyboard layout.

[aioutecism]

Also, the dead key problem will be solved too if "real key" binding is possible.

[erikbra]

aioutecism/amVim-for-VSCode#46 (I didn't manage to test it - low skills developing Code plugins :))

[aioutecism]

Thank you @erikbra!
I leaved some comments #46.

[alexdima]

https://github.com/alexandrudima/vscode-vim shows how to better handle keyboard input in the case of a vim extension

[aioutecism]

Well, yes, listening to type event can solve the layout problem of vim extension.
But, if an extension want to add custom function when cmd+\ is pressed, we still need to deal with different keyboard layout since cmd+\ is not passed to type.
Having type event gives developers a workaround for some problem. But doesn't solve the problem that keybinding settings is not binding the "real" key.

[alexdima]

Unfortunately, all the commands of vscode itself have the same limitation. This is not a limitation we have added, it was a design choice done by w3c when they drafted the keydown event specification.

We can revisit this once Chromium decides to implement KeyboardEvent.key in a correct way, so it is ok with me to keep this open as a tracking issue.

[aioutecism]

Thanks! Looking forward to the fix.

[alexdima]

This is now done via #130396 , where extensions can contribute scan code based keybindings. the full list of scan codes.