Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes notification show even if vscode downgrades to an older version #4141

Closed
isidorn opened this issue Mar 14, 2016 · 1 comment
Closed

Release notes notification show even if vscode downgrades to an older version #4141

isidorn opened this issue Mar 14, 2016 · 1 comment
Assignees
@joaomoreno
Labels
verified Verification succeeded

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 14, 2016

related to #4023

Steps to Reproduce:

  1. Open local storage and modify key storage://global/releasenotes/lastversion to 1.0.0
  2. Reload code - notice how we show the release notes popup
  3. I would not show the release notes in a scenario where we downgrade a VSCode version - as the user has probably already seen those release notes in the past
@joaomoreno
Copy link
Member

This doesn't happen often, I doubt that it will be an issue.

@isidorn isidorn added the verified Verification succeeded label Mar 18, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaomoreno @isidorn