Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate 'isWatching' could be true if task has 'watch' in name #4184

Closed
isidorn opened this issue Mar 14, 2016 · 2 comments
Closed

Generate 'isWatching' could be true if task has 'watch' in name #4184

isidorn opened this issue Mar 14, 2016 · 2 comments
Assignees
Labels
tasks Task system issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 14, 2016

Related to #4019

When generating a tasks.json we always set the isWatching to false, however we could use a simple heuristic to set this to true if a task name has 'watch' in the name. IMHO this heuristic could work nicely in practice.

To repro, just generate tasks.json for vscode repo

@isidorn isidorn added feature-request Request for new features or functionality tasks Task system issues labels Mar 14, 2016
@dbaeumer dbaeumer added this to the Backlog milestone Mar 14, 2016
@dbaeumer
Copy link
Member

@isidorn nice idea, but not easy to realize. The problem is that when in watching mode you need special regular expression to determine in the output when the task is active and when inactive. Otherwise the spinner will not stop :-).

@dbaeumer
Copy link
Member

For task 2.0.0 I implemented that isBackground will be true if the associated matcher has a background property. This is a stronger indication than a name.

@dbaeumer dbaeumer removed the feature-request Request for new features or functionality label Nov 10, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tasks Task system issues
Projects
None yet
Development

No branches or pull requests

2 participants