vscode.workspace.onDidChangeTextDocument is called with no changes

[fabiospampinato]

I've noticed the function passed to vscode.workspace.onDidChangeTextDocument gets called twice if I just insert a new line into the document, the first time it gets called contentChanges is empty.

An extension might perform a lot of work when the document changes, triggering this event without any actual change seems pretty wasteful.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• onDidChangeTextDocument Api timing issue (#11339)

[fabiospampinato]

contentChanges seems to be empty only after the very first change to the document.

[alexdima]

I believe there was an unfortunate idea to call this event when the file gets saved ... or something along those lines. IMHO we should remove that.

[jrieken]

That's the current design and when the dirty-state changes the event is being send. Not sure we can change this without breaking others

[fabiospampinato]

@jrieken from what I can see the function passed to onDidChangeTextDocument is called twice in succession after the very first edit, if somebody for some reason is relying on this behavior they are probably writing bad code.

[jrieken]

I am not here to judge code quality but my role is to not break existing extensions ;-) I think checking the contentChanges-array for being empty isn't a high burden. It's also documented like that

This usually happens when the contents changes but also when other things like the dirty-state changes.

[jrieken]

Closing because no code change is planned