Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated imports: wrong preview in hover #50620

Closed
bpasero opened this issue May 29, 2018 · 2 comments
Closed

Automated imports: wrong preview in hover #50620

bpasero opened this issue May 29, 2018 · 2 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Milestone
May 2018

Comments

@bpasero
Copy link
Member

bpasero commented May 29, 2018

Refs: #50488

The preview shows an import that uses an absolute file path on disk even though the result is not like that (rather import { IEditorService } from "vs/workbench/services/editor/common/editorService";)

image
@bpasero
Copy link
Member Author

bpasero commented May 29, 2018

Hm maybe this is actually unrelated to the automated import but rather a hint how TS found the symbol. Still, would be nice to get the same module path showing up what the automated import would produce.

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 1, 2018

I believe this was fixed by TS 2.9.1 final:

screen shot 2018-06-01 at 2 56 51 pm

@mjbvz mjbvz closed this as completed Jun 1, 2018
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jun 1, 2018
@mjbvz mjbvz added this to the May 2018 milestone Jun 1, 2018
@mjbvz mjbvz added verified Verification succeeded typescript Typescript support issues javascript JavaScript support issues labels Jun 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
2 participants
@bpasero @mjbvz