Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Imports On File Move: alert the user when they're not using the correct TS version #50808

Closed
miguelsolorio opened this issue May 30, 2018 · 1 comment
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code typescript Typescript support issues

Comments

@miguelsolorio
Copy link
Contributor

Issue Type: Bug

Testing #50488

If the user has the "javascript.updateImportsOnFileMove" setting enabled but hasn't set the correct version of TypeScript, we should alert the user that they need to select the correct version. It would be even better if it asked if they want to let VS Code do it for them.

VS Code version: Code - Insiders 1.24.0-insider (bfd155e, 2018-05-29T06:13:09.810Z)
OS version: Darwin x64 17.5.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 4, 4, 4
Memory (System) 16.00GB (0.62GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_5203190
Screen Reader no
VM 20%
@vscodebot vscodebot bot added the insiders label May 30, 2018
@octref octref added typescript Typescript support issues and removed insiders labels May 30, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented May 30, 2018

Good suggestion but I don't think it is worth the effort and maintenance cost. The vast majority of our uses are using the workspace version of typescript which does support this feature. Users will only not see this feature if they have specifically opted to use an older workspace version of TypeScript (in which case, they likely do not want to change their version)

@mjbvz mjbvz closed this as completed May 30, 2018
@mjbvz mjbvz added the *out-of-scope Posted issue is not in scope of VS Code label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*out-of-scope Posted issue is not in scope of VS Code typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

3 participants