Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fault tolerant parser for collecting launch config metadata #51100

Closed
RMacfarlane opened this issue Jun 4, 2018 · 1 comment
Closed

Use fault tolerant parser for collecting launch config metadata #51100

RMacfarlane opened this issue Jun 4, 2018 · 1 comment
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-diagnostics General VS Code built-in diagnostic issues
Milestone
June 2018

Comments

@RMacfarlane
Copy link
Contributor

Copying from #50828:
image

JSON.parse fails on the launch file because it has comments, so the message is printed.
@RMacfarlane RMacfarlane added the workbench-diagnostics General VS Code built-in diagnostic issues label Jun 4, 2018
@RMacfarlane RMacfarlane added this to the June 2018 milestone Jun 4, 2018
@RMacfarlane RMacfarlane self-assigned this Jun 4, 2018
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Jun 4, 2018
@RMacfarlane
Copy link
Contributor Author

RMacfarlane commented Jun 4, 2018 •
edited
Loading

To verify, run code-insiders --status when an instance of VSCode is open on the VSCode repo and confirm that there is a "Launch config" section at the end of the output. launch.json that have comments or trailing comments should be parsed, if the file is malformed in some other way it should still print Unable to parse

@RMacfarlane RMacfarlane mentioned this issue Jun 4, 2018
Closed
@mjbvz mjbvz added the verified Verification succeeded label Jun 28, 2018
@mjbvz mjbvz mentioned this issue Jun 28, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-diagnostics General VS Code built-in diagnostic issues
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
2 participants
@RMacfarlane @mjbvz