Emojis don't take enough space, some stay floating.

[berithpy]

I found similar issues but not exact ones. I was scrolling through my shell history with the up arrow in the keyboard and after going past some emojis they stayed floating there (the eggplant and fire one) after clearing and changing folders some of the remnants disappeared.

• VSCode Version: 1.24
• OS Version: Ubuntu 18.04

Steps to Reproduce:

1.Use color emojis on the terminal

Does this issue occur when all extensions are disabled?: Yes

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Windows emoji keyboard does not work with integrated terminal (#35266)

[berithpy]

Some more info, it looks like the emojis remove spaces from their left when you are scrolling through your shell history.

[Tyriar]

Created upstream issue: xtermjs/xterm.js#1502

@berithpy can you comment exact repro steps how you got to this state? Really granular at like the keystroke level like "foo", enter, etc...

[berithpy]

ok!

• Open the integrated terminal
• Create a folder with an emoji as its name with mkdir 🍆
• Open the folder with cd 🍆
• Use ls
• Scroll through those three commands with ↑ key or ↓ key like this ↑↑ ↓↓ ↑↑ ↓↓ ↑↑ ↓↓ multiple times.

To input the emojis I pasted or wrote them with the special character input (ctrl+shift+u) it didn't seem to make a difference.
Gif example, sorry for the quality!

[vexx32]

I'd also like to bring up that a majority of Gitmoji do not render correctly:

Not sure if this should be in a separate issue or not, though. 😄

[seva0stapenko]

The issue with emoji spacing and subsequent issues with viewing/editing commands from history can be observed on Macs as well. My setup is OSX Mojave 10.14.6 and VSCode 1.38.1.
PS1 is defined as:
PS1="[[\033[01;38;5;46m]\u[\033[00m]🌀\h: [\033[01;38;5;46m]\W[\033[00m]] $ "

(At) emoji is clipped in VSCode terminal window.
Editing/viewing bash command history is a mess, especially with long commands that span more than a single line.

[Tyriar]

Artifacts left -> xtermjs/xterm.js#1502

The half width thing is tracked in xtermjs/xterm.js#1709