Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixLike is probably better, but inconsistent? #6770

Closed
alexdima opened this issue May 24, 2016 · 6 comments
Closed

unixLike is probably better, but inconsistent? #6770

alexdima opened this issue May 24, 2016 · 6 comments
Assignees
Labels
terminal General terminal issues that don't fall under another label
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented May 24, 2016

Testing #6654

I am not an expert in unix distributions, and most likely unixLike is a better term than linux/osx, but then we should align and use unixLike everywhere.

For example, in tasks.json (@dbaeumer) and in package.json keybindings contributions we use linux and osx separately. I am not sure about the launch.json (@weinand knows better)

@dbaeumer
Copy link
Member

For tasks I think it is actually useful yo distinguish between Linux and OS X since it refers to programs to be executed which can be different. However thinking about it tasks should even distinguish between different Linux distributions since they can have different disk layouts.

@weinand
Copy link
Contributor

weinand commented May 24, 2016

@alexandrudima where are you seeing the 'unixLike' ?

@alexdima
Copy link
Member Author

integratedTerminal.shell.unixLike configuration option. My point is that in the rest of VSCode we have two explicit settings/options for osx / linux. I wasn't sure what you do for the launch.json (i.e. can there be platform specific settings and how does it look like)

@weinand
Copy link
Contributor

weinand commented May 24, 2016

Yes, I agree keeping Linux and OS X separate is preferred. For debug adapters we use these names:

2016-05-24 14-40-43

@joaomoreno
Copy link
Member

unixLike felt strange to me, when I first saw it. I would keep it separate too.

@Tyriar
Copy link
Member

Tyriar commented May 24, 2016

👍

@Tyriar Tyriar added this to the May 2016 milestone May 24, 2016
@Tyriar Tyriar added the terminal General terminal issues that don't fall under another label label May 24, 2016
@Tyriar Tyriar closed this as completed in d60d803 May 24, 2016
@Tyriar Tyriar assigned alexdima and unassigned Tyriar May 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

5 participants