Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html][css] [custom data] Reload custom data on user setting change or JSON file changes #67750

Closed
aeschli opened this issue Feb 1, 2019 · 3 comments
Closed

[html][css] [custom data] Reload custom data on user setting change or JSON file changes #67750

aeschli opened this issue Feb 1, 2019 · 3 comments
Assignees
@aeschli
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality html HTML support issues
Milestone
On Deck

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2019 •
edited
Loading

  • listen to file changes on the configuration files and set a cutomdatachange event to the css/html language services

  • listen to extension changes

  • show information in the HTML/CSS language server logs which files have been read
@aeschli aeschli changed the title Improve css data editing experience Improve custom data editing experience Feb 1, 2019
@aeschli
Copy link
Contributor Author

aeschli commented Feb 1, 2019

We need to decide what happens with the experimental setting, but if we go with it:

  • listen to configuration changes (settings)
  • listen to changes to the referenced files
  • validate that the paths exists
  • remove the restriction that it has to be a workspace setting

@octref octref added this to the Backlog milestone Feb 1, 2019
@octref octref added feature-request Request for new features or functionality css-less-scss Issues and items concerning CSS,Less,SCSS styling html HTML support issues labels Feb 1, 2019
@octref octref mentioned this issue Jul 8, 2019
Closed
7 tasks
@aeschli aeschli mentioned this issue Aug 27, 2019
Closed
3 tasks
@octref octref changed the title Improve custom data editing experience Reload custom data on user setting change or JSON file changes Aug 28, 2019
@octref octref mentioned this issue Aug 28, 2019
Closed
@octref
Copy link
Contributor

octref commented Aug 28, 2019

I agree with all the rest, except "remove the restriction that it has to be a workspace setting", see #79911 (comment).

@octref octref mentioned this issue Aug 28, 2019
Closed
@octref octref assigned aeschli and unassigned octref May 1, 2020
@aeschli aeschli changed the title Reload custom data on user setting change or JSON file changes [html][css] [custom data] Reload custom data on user setting change or JSON file changes May 5, 2020
@aeschli aeschli modified the milestones: Backlog, On Deck May 5, 2020
@aeschli
Copy link
Contributor Author

aeschli commented Nov 6, 2020

This got fixed a few month back.

@aeschli aeschli closed this as completed Nov 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality html HTML support issues
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
2 participants
@octref @aeschli