Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A long running blocking UI task might trigger reconnection to kick in #83672

Closed
alexdima opened this issue Oct 30, 2019 · 4 comments
Closed

A long running blocking UI task might trigger reconnection to kick in #83672

alexdima opened this issue Oct 30, 2019 · 4 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
August 2020

Comments

@alexdima
Copy link
Member

  • open a large file like checker.ts
  • run F1 > Developer: Force Retokenize
  • this blocks the UI thread for a time period >10s
  • the reconnection dialog pops up when tokenization is finished

The disconnection check should be tweaked to run every 1s and after 10 runs to consider things disconnected rather than the current implementation where it runs once every 10s...
@alexdima alexdima self-assigned this Oct 30, 2019
@alexdima alexdima mentioned this issue Oct 30, 2019
Closed
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Oct 30, 2019
@alexdima alexdima added this to the October 2019 milestone Oct 30, 2019
@alexdima alexdima changed the title A long running blockin UI task might trigger reconnection to kick in A long running blocking UI task might trigger reconnection to kick in Oct 30, 2019
@alexdima alexdima modified the milestones: October 2019, November 2019 Oct 31, 2019
@alexdima alexdima modified the milestones: November 2019, December 2019 Dec 5, 2019
@alexdima alexdima modified the milestones: January 2020, February 2020 Jan 27, 2020
@alexdima alexdima modified the milestones: February 2020, March 2020 Feb 23, 2020
@alexdima alexdima modified the milestones: March 2020, April 2020 Mar 30, 2020
@alexdima alexdima modified the milestones: April 2020, May 2020 Apr 27, 2020
@alexdima alexdima modified the milestones: May 2020, June 2020 Jun 3, 2020
@bpasero bpasero mentioned this issue Jun 4, 2020
Closed
@alexdima alexdima modified the milestones: June 2020, July 2020 Jun 29, 2020
@alexdima alexdima modified the milestones: July 2020, August 2020 Aug 6, 2020
@bpasero
Copy link
Member

bpasero commented Sep 4, 2020

I can open checker.ts just fine in todays web selfhost, but I also think that we have improved tokenization so much that this file is no longer slow or blocking when opening. Not sure if there is another way to verify this?

@alexdima
Copy link
Member Author

alexdima commented Sep 4, 2020

Thanks for looking to verify. Just run F1 > Developer: Force Retokenize on checker.ts. That will block the UI thread for a while.

@bpasero
Copy link
Member

bpasero commented Sep 4, 2020

@alexdima cool, I can tell that this dialog appears (after copying checker.ts 10 times into the same file):

image

And our reconnection dialog did not ;)

@bpasero bpasero added the verified Verification succeeded label Sep 4, 2020
@bpasero
Copy link
Member

bpasero commented Sep 4, 2020

PS: and we did recover!

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
3 participants
@bpasero @alexdima and others