Relative Links are not clickable in Terminal

[sharadgupta-north]

Issue Type: Bug

Building using gcc and none of the relative links are clickable in the Terminal. Absolute links work.
Tried setting "fileLocation": [ "relative", "${workspaceFolder}/out/build"], and still no luck.
Tried possible solutions in #58256 but no luck.

VS Code version: Code 1.41.1 (26076a4, 2019-12-18T15:04:31.999Z)
OS version: Linux x64 5.0.0-37-generic

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 3088)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: disabled_software skia_renderer: disabled_off surface_control: disabled_off surface_synchronization: enabled_on video_decode: unavailable_off viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off webgl: enabled webgl2: enabled
Load (avg)	3, 3, 3
Memory (System)	31.31GB (1.89GB free)
Process Argv	--no-sandbox --unity-launch
Screen Reader	no
VM	0%

Extensions (15)

Extension	Author (truncated)	Version
alignment	ann	0.3.0
codealignment-vscode	cpm	2.0.19
gitlens	eam	10.2.0
cortex-debug	mar	0.3.4
vscode-docker	ms-	0.9.0
python	ms-	2019.11.50794
cmake-tools	ms-	1.2.3
cpptools	ms-	0.26.2
vs-keybindings	ms-	0.2.0
vsliveshare	ms-	1.0.1404
clang-tidy	not	0.2.2
code-spell-checker	str	1.7.20
cmake	twx	0.0.17
vscodeintellicode	Vis	1.2.2
better-align	wwm	1.1.6

[IllusionMH]

/needsMoreInfo

Can you provide examples of paths that are not clickable?
Most likely duplicate of #21125

[vscodebot]

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

[jacksteamdev]

I'm pretty sure this is a regression. The link below (src/md-sections.test.ts:22:36) isn't clickable.

VS Code Details

Version: 1.41.1
Commit: 26076a4
Date: 2019-12-18T15:04:31.999Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.0.0-20-generic

[Tyriar]

Still work fine for me in the terminal, it's probably related to the cwd of the terminals.

[sharadgupta-north]

Same screen capture, full paths work, relatives don't.

Not sure about the cwd comment, all relative paths are from build folder.

[alexr00]

@sharadgupta-north tasks doesn't do anything special for clickable links in the terminal, it just relies on the terminal link detection. If you run the same command that your task runs manually in the terminal, are the links clickable?

[sharadgupta-north]

No they are not.

[alexr00]

The fileLocation you mentioned in the original post is for the links in Problems that are created from running the task, so it also has no affect on the terminal links.

I suppose tasks could create a new terminal link matcher based on the problem matcher, but right now that's out of scope.

[vscodebot]

We closed this issue because we don't plan to address it in the foreseeable future. You can find more detailed information about our decision-making process here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

[sharadgupta-north]

That was me just trying to fix my problem not the expected solution.
As 'jacksteamdev' mentioned it seems to be a regression and not sure how a regression could be a design decision?
So what you are saying is relative links should not work as clickable links? you are basically excluding a major chunk of your user base.

[alexr00]

Relative links that are relative to the terminal's cwd should be clickable.
Example where the following exist:
c:\one\two\filetwo.txt
c:\one\fileone.txt
Terminal cwd is c:\one.
This relative path should be clickable: fileone.txt
This relative path should be clickable: \two\filetwo.txt
This path is not relative to the cwd and shouldn't be clickable: filetwo.txt.

@Tyriar please correct me if I'm wrong!

[Tyriar]

This relative path should be clickable: fileone.txt
This relative path should be clickable: \two\filetwo.txt
This path is not relative to the cwd and shouldn't be clickable: filetwo.txt.

This is correct that it has to be relative to the cwd that the terminal started in. However, paths must start with .\ or ..\ for Windows. Simply fileone.txt is not specific enough currently (improvements planned in #21125, xtermjs/xterm.js#583)

[alexr00]

@Tyriar thanks for the clarification!
Corrected example:
c:\one\two\filetwo.txt
c:\one\fileone.txt
Terminal starting cwd is c:\one.
This relative path should be clickable: .\fileone.txt
This relative path should be clickable: .\two\filetwo.txt
This path is not relative to the_starting_ cwd and shouldn't be clickable: .\filetwo.txt.