Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File search - include overrides exclude settings #88487

Closed
yoctozepto opened this issue Jan 11, 2020 · 2 comments
Closed

File search - include overrides exclude settings #88487

yoctozepto opened this issue Jan 11, 2020 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@yoctozepto
Copy link

  • VSCode Version: 1.41.1
  • OS Version: platform-irrelevant

Steps to Reproduce:

  1. Use the search feature from the side pane.
  2. Use 'exclude' settings with e.g. .gitignore (for example ignoring doc/build).
  3. Add an 'include' of an overlapping pattern (for example include doc/).
  4. 'Exclude' is now ignored and all 'include' matching are included despite 'exclude' "in effect".

^ The above does not happen when 'exclude' is added there explicitly - then the evaluation order is correct and files are excluded from 'include' as they should be.

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Jan 11, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the search Search widget and operation issues label Jan 11, 2020
@roblourens
Copy link
Member

#26574

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 13, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

2 participants