You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
jmbockhorst opened this issue
Feb 6, 2020
· 4 comments
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugimportantIssue identified as high-priorityverifiedVerification succeededwebIssues related to running VSCode in the web
Running web out of sources does not work as of b1c5e2f because the vscode-api-tests extension cannot activate. When removing the changes from this commit to extensions\vscode-api-tests\src\extension.ts it works as expected.
This was caused by b1c5e2f. Url and TextEncoder are both global types in node but unfortunately the node TypeScript typings don't mark them as such. That's why I added the import instead.
I'll push a fix tomorrow so that we can properly run the extension in both browsers and node.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugIssue identified by VS Code Team member as probable bugimportantIssue identified as high-priorityverifiedVerification succeededwebIssues related to running VSCode in the web
Running web out of sources does not work as of b1c5e2f because the
vscode-api-tests
extension cannot activate. When removing the changes from this commit toextensions\vscode-api-tests\src\extension.ts
it works as expected.Version: 1.42.0-insider (user setup)
Commit: ae08d54
OS: Windows_NT x64 10.0.19546
Steps to Reproduce:
yarn web
The text was updated successfully, but these errors were encountered: