Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sidebar section header colors for default themes #93764

Closed
miguelsolorio opened this issue Mar 30, 2020 · 8 comments
Closed

Update sidebar section header colors for default themes #93764

miguelsolorio opened this issue Mar 30, 2020 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded workbench-views Workbench view issues
Milestone

Comments

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Mar 30, 2020

Current

Proposal

@miguelsolorio miguelsolorio added the themes Color theme issues label Mar 30, 2020
@sandy081 sandy081 added the workbench-views Workbench view issues label Mar 30, 2020
@IllusionMH
Copy link
Contributor

IllusionMH commented Mar 30, 2020

IMHO - harder to spot them now. Especially without more noticeable shadows (particularly at the bottom of explorer tree)

Also might blend with Staged changes, Changes, and Untracked changes blocks (because they don't have background) if any extension adds sections to Source Control tab.

Debugger tab is even more loaded with sections that used frequently and difference in background helps.

@sandy081 sandy081 added the feature-request Request for new features or functionality label Apr 1, 2020
@sandy081 sandy081 self-assigned this Apr 1, 2020
@vscodebot vscodebot bot added this to the Backlog Candidates milestone Apr 1, 2020
@vscodebot
Copy link

vscodebot bot commented Apr 1, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@sandy081 sandy081 modified the milestones: Backlog Candidates, Backlog Apr 1, 2020
@sandy081
Copy link
Member

@misolori It seems more team members are liking this light weight sections. What do you think of making this change to some of the default themes?

@bpasero @jrieken FYI

@miguelsolorio miguelsolorio modified the milestones: Backlog, April 2020 Apr 20, 2020
@miguelsolorio miguelsolorio added the verification-needed Verification of issue is requested label Apr 20, 2020
@miguelsolorio
Copy link
Contributor Author

miguelsolorio commented Apr 20, 2020

Let's try this out and see what people think. I also now show the border in the first view (previously was hidden) since it looked really odd to not have the top border.

One minor issue that happens is when you change from a theme that has a border to one that doesn't, there's a slight shift. But we've always had this issue.

Dark

image

Light

image

@eamodio
Copy link
Contributor

eamodio commented Apr 20, 2020

I like it better than now, but IMHO the borders are too strong.

@alexr00
Copy link
Member

alexr00 commented Apr 29, 2020

Looks good, but I'm not seeing that top border (above Open Editors):
image

@alexr00 alexr00 reopened this Apr 29, 2020
@alexr00 alexr00 added the verification-found Issue verification failed label Apr 29, 2020
@bpasero
Copy link
Member

bpasero commented Apr 29, 2020

That is intentional. We changed that later I think.

@miguelsolorio
Copy link
Contributor Author

Yea, I forgot to update this issue after we updated but we did remove the top border after discussing it internally. Given your screenshot, I'll mark this as verified. Thanks!

@miguelsolorio miguelsolorio added verified Verification succeeded and removed verification-found Issue verification failed labels Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Development

No branches or pull requests

7 participants