Open new terminal not fully working in web

[osortega]

• VSCode Version: 1.43.2
• OS Version: Debian GNU/Linux 9

Steps to Reproduce:

1. Go to online.visualstudio.com
2. Create an environment and connect to it
3. As soon as it loads, try opening a new terminal

Does this issue occur when all extensions are disabled?: Yes/No

The following is the output I see in the console

[Tyriar]

I'm confused, the red error is talking about the fit xterm.js addon which VS Code doesn't use? 😕 What is app.js?

The not implemented error throws in the web worker ext host by design.

[osortega]

@Tyriar the red error should be irrelevant to this. It was something I was testing independently, inside a VS Code webview.

The other errors are the ones I thought would be relevant for this issue. The problem is that sometimes VS Code seems to render wrongly the terminal.

This is how it looks like when it repros.

It shows up as an empty terminal without the first line I would expect

[osortega]

This happens when resizing the terminal

Seems to be some sort of rendering issue

[jkeech]

@Tyriar, I get this consistently on the first launch of a terminal in VSO, 100% of the time. Looking in the console, this error is reported when I first open the terminal with Ctrl + Shift + C:

ERR [object Event]: Error: [object Event]
    at Object.t [as ensureError] (https://online.visualstudio.com/static/web-standalone/d8e3cca/out/vs/loader.js:7:522)
    at s._createLoadError (https://online.visualstudio.com/static/web-standalone/d8e3cca/out/vs/loader.js:27:162)
    at s._onLoadError (https://online.visualstudio.com/static/web-standalone/d8e3cca/out/vs/loader.js:27:281)
    at i (https://online.visualstudio.com/static/web-standalone/d8e3cca/out/vs/loader.js:28:969)
    at Object.errorback (https://online.visualstudio.com/static/web-standalone/d8e3cca/out/vs/loader.js:29:313)
    at e.triggerErrorback (https://online.visualstudio.com/static/web-standalone/d8e3cca/out/vs/loader.js:13:955)
    at https://online.visualstudio.com/static/web-standalone/d8e3cca/out/vs/loader.js:13:659
    at HTMLScriptElement.i (https://online.visualstudio.com/static/web-standalone/d8e3cca/out/vs/loader.js:14:176)

[Tyriar]

I tried to reproduce but cannot. I see that error though. Why does mine say this not VS Online?

Change since the gif was made?

[jkeech]

@Tyriar, I was using insiders, but it also reproduces in stable (added another gif).

If it helps, the browser is Microsoft Edge Version 83.0.467.0 (Official build) dev (64-bit), on Win10, but I'm also able to reproduce in Chrome Version 80.0.3987.163 (Official Build) (64-bit).

One thing I have noticed is that it only seems to happen if the bash terminal that is being opened is not the first terminal:

[Tyriar]

Ok I can reproduce now, steps:

1. Connect to environment
2. Close terminal if it's open and reload
3. Wait a long time such that the VS Online terminal is created
4. ctrl+shift+`

[Tyriar]

It appears the terminal isn't getting the active class which means the terminal is display: none

.monaco-workbench .pane-body.integrated-terminal .terminal-wrapper.active {
    display: block;
    position: absolute;
    bottom: 2px;
    top: 0;
}

[Tyriar]

Local repro:

1. Run the terminal extension sample https://github.com/microsoft/vscode-extension-samples/tree/master/terminal-sample
2. Run the command "Terminal API: Create Terminal"
3. ctrl+shift+`