Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getLinesViewportData api in verticalObjects is returning range where start line and end line is not visible #9542

Closed
sandy081 opened this issue Jul 20, 2016 · 2 comments
Closed

getLinesViewportData api in verticalObjects is returning range where start line and end line is not visible #9542

sandy081 opened this issue Jul 20, 2016 · 2 comments
Assignees
@alexdima
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded VIM VIM issue
Milestone
August 2016

Comments

@sandy081
Copy link
Member

sandy081 commented Jul 20, 2016 •
edited
Loading

verticalObjects.getLinesViewportData() returns the view lines data those are not visible in the current view port.

  • When a line is wrapped and is not visible completely on the top, Some times start line number value is the wrapped line # which is not visible.
  • End line number is always one number greater than visible end line

As a result, In Vim:

  • H and L commands seem to go to outside the view.
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug api labels Jul 20, 2016
@sandy081 sandy081 added this to the August 2016 milestone Jul 20, 2016
@egamma egamma mentioned this issue Jul 20, 2016
Closed
4 tasks
@sandy081 sandy081 mentioned this issue Jul 21, 2016
Closed
@Tyriar Tyriar mentioned this issue Jul 26, 2016
Closed
1 task
@sandy081 sandy081 mentioned this issue Jul 27, 2016
Closed
@sandy081 sandy081 added editor VIM VIM issue labels Jul 27, 2016
@sandy081 sandy081 changed the title getLinesViewportData api in verticalObjects is returning range where end line is not visible getLinesViewportData api in verticalObjects is returning range where start line and end line is not visible Jul 27, 2016
@sandy081 sandy081 removed their assignment Aug 3, 2016
@sandy081 sandy081 removed this from the August 2016 milestone Aug 3, 2016
@alexdima alexdima added this to the August 2016 milestone Aug 16, 2016
@sandy081
Copy link
Member Author

Closing this, since this is no longer an issue for VIM.

@alexdima
Copy link
Member

@sandy081 Opened #10934 to follow up

@sandy081 sandy081 added the verified Verification succeeded label Sep 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded VIM VIM issue
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
2 participants
@alexdima @sandy081