Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command links in settings message don't work #96680

Closed
jrieken opened this issue Apr 30, 2020 · 1 comment
Closed

Command links in settings message don't work #96680

jrieken opened this issue Apr 30, 2020 · 1 comment
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) settings-editor VS Code settings editor issues

Comments

@jrieken
Copy link
Member

jrieken commented Apr 30, 2020

re #91618

  • have message that uses a command link, e.g Hello [command](command:deleteLeft)
  • this isn't becoming a link

Because of security concerns, command-links must be enabled via the isTrusted-flag. Because these links are from extensions they should be trusted
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Apr 30, 2020
@roblourens roblourens modified the milestones: April 2020, May 2020 Apr 30, 2020
@roblourens roblourens added the debt Code quality issues label Apr 30, 2020
@roblourens roblourens modified the milestones: May 2020, June 2020 Jun 2, 2020
@roblourens
Copy link
Member

#71295

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 30, 2020
@roblourens roblourens removed this from the June 2020 milestone Jun 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) settings-editor VS Code settings editor issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @jrieken