Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Simple use cases are failing for testing in multi-targetting projects on VS2017 for win10-x64 #864

Closed
ghost opened this issue Jun 14, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Jun 14, 2017

Steps to reproduce

Please clone https://github.com/fir3pho3nixx/nunit-adapter-vs-xunit/tree/missing-package-with-error-message-that-is-simply-wrong

Then run: build.bat

Expected behavior

It does NOT kick out: Make sure test project has a nuget reference of package "microsoft.testplatform.testhost". This is the wrong package, in my case I was missing a package reference to:

<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0" />

This happens for both NUnit and XUnit. You can observe this by commenting out this line.

Actual behavior

It kicks out: Make sure test project has a nuget reference of package "microsoft.testplatform.testhost".

Environment data

dotnet --info output:

.NET Command Line Tools (1.0.4)

Product Information:
Version: 1.0.4
Commit SHA-1 hash: af1e6684fd

Runtime Environment:
OS Name: Windows
OS Version: 10.0.14393
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\1.0.4

More info

Please see https://github.com/dotnet/cli/issues/6856 for some background.

@Faizan2304
Copy link
Contributor

Thanks @fir3pho3nixx for opening this issue with us. Its a known issue and we have fixed it. PR

The new message looks like
No test is available in TestprojectName.dll. Make sure test project has a nuget reference of package "Microsoft.NET.Test.Sdk" and framework version settings are appropriate and try again.

@ghost
Copy link
Author

ghost commented Jun 15, 2017

Good stuff! Look forward to it being released 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant