Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many constants are missing values #88

Closed
kennykerr opened this issue Jan 8, 2021 · 1 comment
Closed

Many constants are missing values #88

kennykerr opened this issue Jan 8, 2021 · 1 comment
Labels
broken api An API is inaccurate and could lead to runtime failure

Comments

@kennykerr
Copy link
Contributor

For example, here's how JS_SOURCE_CONTEXT_NONE is defined in the original header:

const JsSourceContext JS_SOURCE_CONTEXT_NONE = (JsSourceContext)-1;

But here's what shows up in metadata:

public const UIntPtr JS_SOURCE_CONTEXT_NONE = default(UIntPtr);

Many dozens of other such examples. Perhaps an assert that verifies each constant has a literal value would help to avoid regressions.

Another example:

static const WCHAR g_wszWMUse_DRM[] = L"Use_DRM";

Becomes:

public const string g_wszWMUse_DRM = null;
@AArnott AArnott added the broken api An API is inaccurate and could lead to runtime failure label Jan 14, 2021
@kennykerr kennykerr added the hot label Jan 25, 2021
@kennykerr kennykerr removed the hot label Feb 3, 2021
@sotteson1
Copy link
Contributor

The ones in the bug are fixed. If you see others let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken api An API is inaccurate and could lead to runtime failure
Projects
None yet
Development

No branches or pull requests

3 participants