Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: Gyan.FFmpeg does not uninstall correctly #2949

Closed
2 tasks done
mstevens83 opened this issue Feb 10, 2023 · 5 comments
Closed
2 tasks done

[Package Issue]: Gyan.FFmpeg does not uninstall correctly #2949

mstevens83 opened this issue Feb 10, 2023 · 5 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Portable Issue related to portable package
Milestone

Comments

@mstevens83
Copy link

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

Package Gyan.FFmpeg (v5.1.2) does not properly uninstall:
image

I'm using --force because otherwise it refuses to uninstall due to the package being supposedly modified, which is not the case. I even get this straight away after installing it fresh.

Notice I'm running this as Administrator because that also how I install it (due to microsoft/winget-pkgs#95349 / #2909).

Steps to reproduce

(As administrator:)
winget install gyan.ffmpeg
winget uninstall gyan.ffmpeg (complains about the package being modified, which is not the case)
winget uninstall gyan.ffmpeg --force

Actual behavior

%LOCALAPPDATA%\Microsoft\WinGet\Packages\Gyan.FFmpeg_Microsoft.Winget.Source_8wekyb3d8bbwe and subfolder/files remain behind.

Expected behavior

All files/folders related to package are gone.

Environment

Windows Package Manager v1.4.10173
Windows: Windows.Desktop v10.0.22621.1105
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0


Gyan.FFmpeg v5.1.2

Screenshots and Logs

No response

@mstevens83 mstevens83 added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Feb 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Feb 10, 2023
@Trenly
Copy link
Contributor

Trenly commented Feb 10, 2023

I'm using --force because otherwise it refuses to uninstall due to the package being supposedly modified, which is not the case. I even get this straight away after installing it fresh.

@denelon - sounds like a CLI issue

Actual behavior

%LOCALAPPDATA%\Microsoft\WinGet\Packages\Gyan.FFmpeg_Microsoft.Winget.Source_8wekyb3d8bbwe and subfolder/files remain behind.

Expected behavior

All files/folders related to package are gone.

If any files are created in the folder outside of just the ffmpeg application, the default behavior of winget is to preserve them when uninstalling to avoid removing user data. You can override this using --purge when uninstalling or by setting the default behavior to purge in winget settings

@denelon denelon transferred this issue from microsoft/winget-pkgs Feb 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Feb 10, 2023
@microsoft-github-policy-service

This comment was marked as off-topic.

@denelon denelon removed Needs-Triage Issue need to be triaged Needs-Author-Feedback Issue needs attention from issue or PR author labels Feb 10, 2023
@denelon denelon reopened this Feb 10, 2023
@denelon denelon added this to the v1.5-Client milestone Feb 14, 2023
@denelon denelon added this to WinGet Feb 14, 2023
@denelon denelon added the Portable Issue related to portable package label Feb 21, 2023
@denelon denelon modified the milestones: v1.5-Client, v.Next-Client Apr 19, 2023
@mdanish-kh
Copy link
Contributor

This has been fixed in WinGet v1.5.1081-preview release through PR #3002

cc @denelon

@denelon denelon closed this as completed May 1, 2023
@github-project-automation github-project-automation bot moved this to Done in WinGet May 1, 2023
@denelon denelon modified the milestones: v.Next-Client, v1.5-Client May 5, 2023
@denelon denelon removed this from WinGet Jul 6, 2023
@alexyo02
Copy link

alexyo02 commented Aug 22, 2023

Hi, still have the same problem on the latest stable version of Winget (v1.5.2201), on Windows 11 22h2. No matter what command I use, the process is stuck

@mdanish-kh
Copy link
Contributor

@alexyo02 That is probably related to #3279. There are a couple workarounds to fix the uninstall mentioned in that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Portable Issue related to portable package
Projects
None yet
Development

No branches or pull requests

5 participants