Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SpellChecker to GH Action #559

Closed
WSLUser opened this issue Sep 4, 2020 · 4 comments · Fixed by #645
Closed

Add SpellChecker to GH Action #559

WSLUser opened this issue Sep 4, 2020 · 4 comments · Fixed by #645
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs
Milestone
v1.3-Client

Comments

@WSLUser
Copy link

WSLUser commented Sep 4, 2020 •
edited
Loading

Adding the Spellchecker will help with docs and code with misspellings. You can find it here: https://github.com/jsoref/spelling and is available in the GH Action Marketplace. Windows Terminal is already using it for example: microsoft/terminal#4799
@WSLUser WSLUser added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs label Sep 4, 2020
@ghost ghost added the Needs-Triage Issue need to be triaged label Sep 4, 2020
@denelon denelon removed the Needs-Triage Issue need to be triaged label Sep 8, 2020
@denelon denelon self-assigned this Sep 16, 2020
@WSLUser
Copy link
Author

WSLUser commented Sep 28, 2020

Since this has been assigned, summoning @jsoref to help winget adopt this.

@ghost ghost mentioned this issue Nov 14, 2020
Closed
@ghost
Copy link

ghost commented Nov 14, 2020

PowerToys also recently adopted this: microsoft/PowerToys#7700

@jsoref jsoref mentioned this issue Nov 14, 2020
Merged
@ghost ghost added the In-PR Issue related to a PR label Nov 14, 2020
@jsoref
Copy link
Contributor

jsoref commented Nov 14, 2020

@WSLUser, sorry for the delay, not sure how I missed this. I will watch the repo for a bit after it merges to ensure a smooth ride.

@denelon
Copy link
Contributor

denelon commented Nov 16, 2020

@jsoref, I've asked @JohnMcPMS to take a look at the PR.

@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Nov 16, 2020
@denelon denelon added this to the v1.3-Client milestone Jun 21, 2022
@denelon denelon removed their assignment Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs
Projects
None yet
Milestone
v1.3-Client
Development

Successfully merging a pull request may close this issue.

Spell check jsoref/winget-cli
3 participants
@jsoref @WSLUser @denelon