Moved "Installing Dependencies" message to only print if there are dependencies to install. #1851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to make sure that the "Installing Dependencies: " string only prints if there are actually dependencies installing. The way it was, if all of the dependencies were already installed it looked like the package the user requested was a dependency.
(Note how the 6th line isn't "Installing Dependencies")
I suppose the other change should be that the "This package requires the following dependencies" list shouldn't be presented if you have all of the dependencies already installed (since if you want the full list you can get it via
winget show
anyway), but that'll probably require a couple changes toReportDependencies()
.Microsoft Reviewers: Open in CodeFlow