Better handling of min version merging in DependencyList #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
approved these changes
Nov 19, 2024
JohnMcPMS
added a commit
to JohnMcPMS/winget-cli
that referenced
this pull request
Nov 21, 2024
) Likely fix for microsoft#4972 ## Change Use `std::optional` overloaded operator to handle all of the comparisons in `DependencyList::Add`. The operator already properly handles all of the cases, including treating `std::nullopt` as always less than a defined value. Also optimize a few other places around a reference to `MinVersion`. ## Validation Added a unit test covering the cases where `Add` needs to merge the minimum version value.
JohnMcPMS
added a commit
that referenced
this pull request
Nov 22, 2024
[Cherry pick #4987 to 1.9] Likely fix for #4972 ## Change Use `std::optional` overloaded operator to handle all of the comparisons in `DependencyList::Add`. The operator already properly handles all of the cases, including treating `std::nullopt` as always less than a defined value. Also optimize a few other places around a reference to `MinVersion`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely fix for #4972
Change
Use
std::optionaloverloaded operator to handle all of the comparisons inDependencyList::Add. The operator already properly handles all of the cases, including treatingstd::nulloptas always less than a defined value.Also optimize a few other places around a reference to
MinVersion.Validation
Added a unit test covering the cases where
Addneeds to merge the minimum version value.Microsoft Reviewers: Open in CodeFlow