You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Every time I try to execute wingetcreate to update/create manifests, it automatically RE-downloads installer files even if they have already been downloaded.
This is too annoying, imagine when you issue a command and it downloads GBs of data then throws an error.
Proposed technical implementation details
Check if files are on local disk, ask users to use them
If you have to download the file every time, at least give us an option to generate manifests using existing files instead of remote ones.
Make downloads resumable.
The text was updated successfully, but these errors were encountered:
jm33-m0
added
the
Issue-Feature
Complex enough to require an in depth planning process and actual budgeted, scheduled work.
label
Oct 13, 2022
Check if files are on local disk, ask users to use them
The issue with doing it this way is that manifest that is created has to have a remote InstallerUrl. winget-create can guarantee the values that its putting into the manifest are correct if it downloads and does the logic itself. The user could be asked for the file, like you said, but a lot of trust is placed on the user that the file that is being inputted is what would be retrieved from the remote URL, and there are lots of cases where the URL may stay the same but the file that it points to changes. Nightly releases, for example.
Make downloads resumable.
Having half-downloaded files persist on the user's disk isn't exactly clean as there's no guarantee that the user will ever even go back and resume it.
It can't be resumed either if we know the user will definitely retry it straight after as you're essentially creating an instance of winget-create while you use it, which is then closed once the command has finished running, so everything in memory that it was using is removed/no longer accessible. Alongside this, if a download has failed mid-way, it's probably going to be very difficult to resume and likely much more preferable to just try it again from scratch.
@jm33-m0 This should be resolved partially in winget-create 1.2.7.0. WinGet-Create will no longer download from same URL twice. But in case of a failure, you would have to run the command again which will cause re-downloads. I am not sure how exactly your other requests can be catered because of the concerns raised by @russellbanks...
Description of the new feature / enhancement
Every time I try to execute
wingetcreate
to update/create manifests, it automatically RE-downloads installer files even if they have already been downloaded.This is too annoying, imagine when you issue a command and it downloads GBs of data then throws an error.
Proposed technical implementation details
The text was updated successfully, but these errors were encountered: