Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift fields back to installer level for re-run #439

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Aug 22, 2023

The common installer fields get shifted to root level after running through the new command once. But if a user requests a re-run / retry, the internal logic fails as it expects fields at the installer level. Updated the code to shift fields back to installer level for re-run


Microsoft Reviewers: Open in CodeFlow

@mdanish-kh mdanish-kh requested a review from a team as a code owner August 22, 2023 20:02
@mdanish-kh mdanish-kh requested review from yao-msft and ryfu-msft and removed request for a team August 22, 2023 20:02
@ryfu-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft ryfu-msft merged commit f60137f into microsoft:main Aug 22, 2023
4 checks passed
@mdanish-kh mdanish-kh deleted the shiftToInstallerForReRun branch August 23, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.InvalidOperationException after making changes to manifest
2 participants