Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: OpenJS.NodeJS tries to update to nightly #111537

Closed
2 tasks done
lutzroeder opened this issue Jul 7, 2023 · 9 comments
Closed
2 tasks done

[Package Issue]: OpenJS.NodeJS tries to update to nightly #111537

lutzroeder opened this issue Jul 7, 2023 · 9 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@lutzroeder
Copy link
Member

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Installation issue.

Brief description of your issue

When running update, 20.4.0 is updated to 21.0.0-nightly20230706b5e16adb1d.

@CoolPlayLin @stephengillie #111148

Steps to reproduce

> winget install OpenJS.NodeJS
> winget upgrade
Name    Id            Version Available                        Source
---------------------------------------------------------------------
Node.js OpenJS.NodeJS 20.4.0  21.0.0-nightly20230706b5e16adb1d winget

Actual behavior

The 21.0.0-nightly20230706b5e16adb1d build is offered and installed.

Expected behavior

No new build should be installed and 20.4.0 is the latest available.

Environment

Windows Package Manager (Preview) v1.6.1573-preview
Windows: Windows.Desktop v10.0.22621.1928
System Architecture: Arm64
Package: Microsoft.DesktopAppInstaller v1.21.1573.0

Screenshots and Logs

No response

@lutzroeder lutzroeder added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 7, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jul 7, 2023
@CoolPlayLin
Copy link
Contributor

It's not my problem, I checked it just now. The nightly version is in correct folder

@mdanish-kh
Copy link
Contributor

It's not my problem, I checked it just now. The nightly version is in correct folder

It's an issue with winget upgrade not winget install

@CoolPlayLin
Copy link
Contributor

image
It seems OpenJS.NodeJS as OpenJS.NodeJS.Nightly

@mdanish-kh
Copy link
Contributor

WinGet can't differentiate nightly and stable releases as they use the same Apps&Features entries i.e. same DisplayName, Publisher, UpgradeCode values that causes conflicts in upgrade matching. The solution is likely to be addressed in

For now, the quick fix would be to not support nightly releases in the WinGet repository as they cause conflicts with stable releases. It's hard anyway to keep up-to-date with nightly releases without automation / publisher taking control of the package releases

@mdanish-kh
Copy link
Contributor

@mdanish-kh Move OpenJS.NodeJS.Nightly to OpenJS.NodeJSNightly ?

That won't help, I'm talking about removing nightly releases altogether from the repo; Also seeing your screenshot I noticed that there is another problem with the nightly manifests concerning the DisplayVersion field not being present in all manifests. That is evident from the "<" symbol resulting in infinite upgrade scenario for the end-user.

@lutzroeder
Copy link
Member Author

lutzroeder commented Jul 7, 2023

@mdanish-kh @stephengillie the issue still repros. Is there a local cache that needs to be updated or removal to propagate?

@mdanish-kh
Copy link
Contributor

mdanish-kh commented Jul 7, 2023

@lutzroeder #111562 hasn't yet passed the publish pipeline; Changes will appear once all the PRs have made their way through the publish pipeline

@mdanish-kh
Copy link
Contributor

@lutzroeder All package removal PRs have now passed the publish pipeline; Can you confirm if the issue has been resolved now?

@lutzroeder
Copy link
Member Author

Yes, 20.4.0 is now listed as latest available for OpenJS.NodeJS. Thank you, @mdanish-kh and @stephengillie.

@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

5 participants