-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[awaiting winget update] Channel in all manifests #16271
Comments
Don't believe everything you see in the manifest schema 🙄
Channel is actually the only one which is not supported AFAK, probably because they haven't decided how to do it yet. There is 3 other fields that you can add metadata to, but they don't actually do anything
|
@iDolmatov our early thinking for "channels" is to support packages that are not able to be run side by side like Visual Studio Code and Visual Studio Code Insider. One example of such a package is Docker Desktop. There are several different concerns. One of the primary concerns is if a user has a "beta" build, we don't want to overwrite with the stable build and the reverse is also true. @OfficialEsco is correct. There are several things included in the schema that we either had from 0.2.0 and carried forward, or we have an idea of what we want to implement and just haven't gotten to it yet. Changing the schema has far reaching implications across the client, validation pipelines, publishing pipelines, REST API, wingetcreate, and a few other surfaces. |
When we implement support for microsoft/winget-cli#147 we will likely make a determination of whether or not we update all manifests. |
What? |
You can test if
It also seems like winget-cli does not utilize |
I forgot about this issue and wrote a comment in the previously mentioned issue 147. I am closing the issue unresolved in order to exclude the already large list of active issues. |
I propose to revise the entire list of manifests for the addition of the "Channel" attribute.
Proposed technical implementation details (optional)
// A property of a package version. enum class PackageVersionProperty { Id, Name, SourceIdentifier, SourceName, Version, Channel, RelativePath, // Returned in hexadecimal format ManifestSHA256Hash, };
winget-cli-master\src\AppInstallerRepositoryCore\Public\AppInstallerRepositorySearch.h
At the moment this is ignored and resolved through the package name, which is incorrect if it is possible to specify this in the manifest.
Also, this attribute should be made required in the manifest creation tools. microsoft/winget-cli#147
Filling in this attribute will allow you to prepare in advance the base for testing when implementing other winget functions (searching, installing only test or release versions, placing different channels under the same ID when the program uses the same folder for different channels, etc.).
Add "Channel" to all manifests.
The text was updated successfully, but these errors were encountered: