Remove session dependency in authenticate_header #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. Thanks! |
miguelgrinberg
added a commit
that referenced
this pull request
Feb 7, 2016
Remove session dependency in authenticate_header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when you provide a custom nonce/opaque storage mechanism for HTTPDigestAuth, session is still being accessed. This is unnecessary as appropriate session variables are already being set by the default mechanism and breaks apps that don't use sessions at all (i.e. don't set the SECRET_KEY).
The change proposed here seems to be enough to fix the problem.