-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document support browser versions #29
Comments
For node it would be sufficient to add "The latest Node LTS version is supported" and link to https://github.com/nodejs/Release#lts-schedule. For browsers I’d say it’s safe to say that all browsers are supported. IE 11 and Opera Mini need a fetch polyfill. Maybe link to https://caniuse.com/#feat=fetch and for the browser support (as well as react native) link to https://www.npmjs.com/package/whatwg-fetch for a polyfill |
If all browsers are supported, then why not all nodes? |
*All evergreen browsers are supported.
Read more about the motivation here: Stop supporting old releases Lines 6 to 8 in 0a93782
It's not that I wouldn’t support all Node versions, but I wouldn’t do it ourselves. But we could add a way for others to sign up to support older Node versions and backport new features / fixes |
Yes, I’m familiar with that article and position, and think it’s hugely harmful to the ecosystem - but that philosophy also indeed means all evergreen browsers, which would mean no IE or Opera whatsoever. Why support those if not older nodes? |
Good point, thanks Jordan! Let’s not officially support IE or Opera. It could work with a fetch polyfill, but no guarantees. |
At least that will be consistent :-) |
Please document the support browser and Node versions.
At least for the browsers, I believe this to be very limited given there isn't any employment of a browser-side polyfill here if the Fetch API is not available. I think many people would be surprised by that when coming to the "spiritual successor of
request
". Granted, that issue could be solved by incorporating something like #27 (usingisomorphic-fetch
rather than justnode-fetch
) if desired.The text was updated successfully, but these errors were encountered: