Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic require() breaks RN 49.0+ #214

Closed
agrosner opened this issue Oct 5, 2017 · 3 comments · Fixed by #218
Closed

Dynamic require() breaks RN 49.0+ #214

agrosner opened this issue Oct 5, 2017 · 3 comments · Fixed by #218

Comments

@agrosner
Copy link

agrosner commented Oct 5, 2017 •
edited
Loading

screen shot 2017-10-05 at 4 31 47 pm

This error appears when trying to run our app with react native 0.49. It appears to be breaking a few other libraries including realm and moment.js (facebook/react-native#16216)
@konradkierus
Copy link
Contributor

Yep, but I can confirm that fixing this in realm way realm/realm-js@e1b70c2 does fix the issue but... there is a debate going on here facebook/metro#52 (packager for React Native) if this shouldn't be fixed on packager itself.
Anyway, realm workaround wouldn't harm here.

konradkierus pushed a commit to konradkierus/validatorjs that referenced this issue Oct 9, 2017
Workaround for mikeerickson#214 and proper workaround/fix for propose…
7c451cc 
…d changes in metro bundler facebook/metro#69
@danieloprado
Copy link

@konradkierus make a pull request

@danieloprado danieloprado mentioned this issue Oct 18, 2017
Merged
@konradkierus
Copy link
Contributor

@danieloprado I didn't want to do this as there is still a debate on metro-bundler if it shouldn't have an option to allow dynamic imports facebook/metro#65
But! The workaround doesn't break anything so it could be merged if project's author is ok with this.

mikeerickson added a commit that referenced this issue Nov 7, 2017
@mikeerickson
Merge pull request #218 from danieloprado/master
425eb1f 
Workaround for #214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Workaround for #214 danieloprado/validatorjs
3 participants
@agrosner @danieloprado @konradkierus